rename local-variable 'L' to 'luaVMInstance' #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…VMInstance'.make it more intelligible
aooohan
approved these changes
Dec 22, 2023
aooohan
added a commit
that referenced
this pull request
Mar 26, 2024
# This is the 1st commit message: fix: manifest url # This is the commit message #2: doc(readme): add roadmap # This is the commit message #3: doc(readme): add roadmap # This is the commit message #4: feat: support loong64 arch fix #142 # This is the commit message #5: ci: add coverage and codecov (#138) * ci: add coverage and codecov * ci: fix testcases * ci: test all cases * ci: fix testcase on ubuntu * ci: add macos and windows * ci: show err * ci: update ci * ci: fix testcase * ci: cancel previous run * ci: skip case on windows * ci: update workflow # This is the commit message #6: fetch plugin from registry # This is the commit message #7: remove author field # This is the commit message #8: Load the corresponding hook when calling # This is the commit message #9: revert # This is the commit message #10: chore: smplified code fix: unmarshal should based on type of golang (#137) * fix: unmarshal should based on type of golang * fix: encoding map[int] will cause error * chore: update comment * test: update testcase * test: update testcase * Update internal/luai/example_test.go * test: fix testcases * test: fix testcases --------- Co-authored-by: Han Li <lihan@apache.org> mod fix: separate processing of PATH, ensuring order and de-duplication. fix #144 #74 fix: test Refactor: Load new template plugins and be compatible with old formats (#136) * Refactoring plugin loading mechanism, support for both old and new templates * fix: manifest url * remove author field * Load the corresponding hook when calling * revert * mod add plugin from registry bugfix udpate plugin from registry udpate plugin from registry bugfix
aooohan
added a commit
that referenced
this pull request
Mar 26, 2024
# This is the 1st commit message: fix: manifest url # This is the commit message #2: doc(readme): add roadmap # This is the commit message #3: doc(readme): add roadmap # This is the commit message #4: feat: support loong64 arch fix #142 # This is the commit message #5: ci: add coverage and codecov (#138) * ci: add coverage and codecov * ci: fix testcases * ci: test all cases * ci: fix testcase on ubuntu * ci: add macos and windows * ci: show err * ci: update ci * ci: fix testcase * ci: cancel previous run * ci: skip case on windows * ci: update workflow # This is the commit message #6: fetch plugin from registry # This is the commit message #7: remove author field # This is the commit message #8: Load the corresponding hook when calling # This is the commit message #9: revert # This is the commit message #10: chore: smplified code fix: unmarshal should based on type of golang (#137) * fix: unmarshal should based on type of golang * fix: encoding map[int] will cause error * chore: update comment * test: update testcase * test: update testcase * Update internal/luai/example_test.go * test: fix testcases * test: fix testcases --------- Co-authored-by: Han Li <lihan@apache.org> mod fix: separate processing of PATH, ensuring order and de-duplication. fix #144 #74 fix: test Refactor: Load new template plugins and be compatible with old formats (#136) * Refactoring plugin loading mechanism, support for both old and new templates * fix: manifest url * remove author field * Load the corresponding hook when calling * revert * mod add plugin from registry bugfix udpate plugin from registry udpate plugin from registry bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file 'plugin.go' line 318 instance a local-variable which named 'L':which is a Lua VM 's instance.It's not a particularly clear naming so I rename 'L' to 'luaVMInstance'.Intended to make people more accurate to know its role